Skip to content

Tests: Pass a number of necessary done() calls to assert.async() #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Mar 2, 2020
Merged

Tests: Pass a number of necessary done() calls to assert.async() #4633

mgol merged 1 commit into from
Mar 2, 2020

Conversation

@mgol
Copy link
Member

@mgol mgol commented Feb 28, 2020 •
edited
Loading

Summary

It is no longer needed to create done wrappers in tests that require multiple
async operations to complete.

Checklist

@mgol
Tests: Pass a number of necessary done() calls to assert.async()
25aa0f1 
It is no longer needed to create `done` wrappers in tests that require multiple
async operations to complete.
@mgol mgol self-assigned this Feb 28, 2020
@mgol mgol merged commit 364476c into jquery:master Mar 2, 2020
@mgol mgol deleted the test-done-simplification branch March 2, 2020 21:15
@mgol mgol removed the Needs review label Mar 2, 2020
mgol added a commit that referenced this pull request Mar 2, 2020
@mgol
Tests: Pass a number of necessary done() calls to assert.async()
5ea844f 
It is no longer needed to create `done` wrappers in tests that require
multiple async operations to complete.

Closes gh-4633

(cherry picked from commit 364476c)
@mgol mgol added this to the 3.5.0 milestone Mar 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels

Tests

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @timmywil