Skip to content

Build: Add intuitive names to Travis jobs #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Jan 20, 2020

Summary

Otherwise it's hard to see at a glance that a particular job is running
on Firefox ESR, for example.

I left the build & Node.js configuration intact as I think current UI is clear enough there.

Checklist

Sorry, something went wrong.

Otherwise it's hard to see at a glance that a particular job is running
on Firefox ESR, for example.
@mgol mgol added this to the 3.5.0 milestone Jan 20, 2020
@mgol mgol self-assigned this Jan 20, 2020
@mgol mgol marked this pull request as ready for review January 20, 2020 11:52
@mgol
Copy link
Member Author

mgol commented Jan 20, 2020

Before:
Screen Shot 2020-01-20 at 12 46 04
After:
Screen Shot 2020-01-20 at 12 54 58
Suggestions to further improve wording welcome!

Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@mgol mgol removed the Needs review label Jan 20, 2020
@mgol mgol merged commit e1fab10 into jquery:master Jan 20, 2020
@mgol mgol deleted the travis-names branch January 20, 2020 18:19
@mgol mgol modified the milestones: 3.5.0, 4.0.0 Jan 21, 2020
@mgol
Copy link
Member Author

mgol commented Jan 21, 2020

Changing milestones, I'll submit a separate PR for the 3.x-stable branch as the changes there will be slightly different.

mgol added a commit to mgol/jquery that referenced this pull request Jan 21, 2020
This commit fixes unit tests for the following builds:

1. The no-deprecated build: `custom:-deprecated`
2. The current slim build: `custom:-ajax,-effects`
3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref jquerygh-4577
Ref jquerygh-4596
mgol added a commit to mgol/jquery that referenced this pull request Jan 21, 2020
This commit fixes unit tests for the following builds:

1. The no-deprecated build: `custom:-deprecated`
2. The current slim build: `custom:-ajax,-effects`
3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref jquerygh-4577
Ref jquerygh-4596
mgol added a commit to mgol/jquery that referenced this pull request Jan 21, 2020
This commit fixes unit tests for the following builds:

1. The no-deprecated build: `custom:-deprecated`
2. The current slim build: `custom:-ajax,-effects`
3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref jquerygh-4577
Ref jquerygh-4596
@mgol
Copy link
Member Author

mgol commented Jan 21, 2020

PR to 3.x-stable: #4600.

mgol added a commit that referenced this pull request Jan 27, 2020
This commit fixes unit tests for the following builds:

1. The no-deprecated build: `custom:-deprecated`
2. The current slim build: `custom:-ajax,-effects`
3. The 4.0 (#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref gh-4577
Ref gh-4596
Closes gh-4600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants