Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Jan 8, 2020

Summary

This removes a needless function call in modern browsers.

+3 bytes

Checklist

@mgol mgol added the Attributes label Jan 8, 2020
@mgol mgol self-assigned this Jan 8, 2020
@mgol mgol changed the title Attributes: Don't set the type attrHooks at all outside of IE Attributes: Don't set the type attr hook at all outside of IE Jan 8, 2020
This removes a needless function call in modern browsers.
@mgol mgol force-pushed the attrhooks-type-perf branch from 5092f27 to 4ec4a7e Compare January 8, 2020 17:24
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@mgol mgol merged commit 9e66fe9 into jquery:master Jan 13, 2020
@mgol mgol deleted the attrhooks-type-perf branch January 13, 2020 18:22
@mgol mgol added this to the 4.0.0 milestone Jan 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants