Build:Tests: Fix custom build tests, verify on Travis #4577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mgol
force-pushed
the
custom-builds-fixes
branch
2 times, most recently
from
bca6bd7 to
ef1578f
Compare
timmywil
requested changes
Jan 7, 2020
mgol
force-pushed
the
custom-builds-fixes
branch
from
ef1578f to
0f921df
Compare
timmywil
approved these changes
Jan 7, 2020
…e 3.x slim build)
…fects` build (i.e. the 4.x slim build)
mgol
force-pushed
the
custom-builds-fixes
branch
from
0f921df to
d191f08
Compare
mgol
changed the title
2 tasks
Member
Author
|
Changing milestones, I'll submit a separate PR for the |
gaohuia
pushed a commit
to gaohuia/jquery
that referenced
this pull request
Jan 9, 2020
This commit fixes unit tests for the following builds: 1. The no-deprecated build: `custom:-deprecated` 2. The current slim build: `custom:-ajax,-effects` 3. The future (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects` It also adds separate Travis jobs for the no-deprecated & slim builds. Closes jquerygh-4577
2 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 21, 2020
This commit fixes unit tests for the following builds: 1. The no-deprecated build: `custom:-deprecated` 2. The current slim build: `custom:-ajax,-effects` 3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects` It also adds separate Travis jobs for the no-deprecated & slim builds. Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see at a glance that a particular job is running on Firefox ESR, for example. Ref jquerygh-4577 Ref jquerygh-4596
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 21, 2020
This commit fixes unit tests for the following builds: 1. The no-deprecated build: `custom:-deprecated` 2. The current slim build: `custom:-ajax,-effects` 3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects` It also adds separate Travis jobs for the no-deprecated & slim builds. Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see at a glance that a particular job is running on Firefox ESR, for example. Ref jquerygh-4577 Ref jquerygh-4596
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jan 21, 2020
This commit fixes unit tests for the following builds: 1. The no-deprecated build: `custom:-deprecated` 2. The current slim build: `custom:-ajax,-effects` 3. The 4.0 (jquery#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects` It also adds separate Travis jobs for the no-deprecated & slim builds. Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see at a glance that a particular job is running on Firefox ESR, for example. Ref jquerygh-4577 Ref jquerygh-4596
3 tasks
Member
Author
|
PR to |
mgol
added a commit
that referenced
this pull request
Jan 27, 2020
This commit fixes unit tests for the following builds: 1. The no-deprecated build: `custom:-deprecated` 2. The current slim build: `custom:-ajax,-effects` 3. The 4.0 (#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects` It also adds separate Travis jobs for the no-deprecated & slim builds. Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see at a glance that a particular job is running on Firefox ESR, for example. Ref gh-4577 Ref gh-4596 Closes gh-4600
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes unit tests for the following builds:
custom:-deprecatedcustom:-ajax,-effectscustom:-ajax,-callbacks,-deferred,-effectsIt also adds separate Karma runs for the no-deprecated & current slim builds. Once the new slim build configuration lands, we'll have to modify what we test on Travis as well.
This PR can also be cherry-picked to
3.x-stable.Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com