All committers have signed the CLA.

Thanks for the PR, I'll have a closer look later. In the meantime, please sign our CLA, this is a requirement for us moving forwards with the PR.

Thanks for your explaination.

@gaohuia Your PR now contains my cherry-picked PRs... Can you instead rebase your PR over current master so that it only contains your code? My commits should disappear then:

git fetch --all --tags -p
git rebase origin/master

If your upstream is named differently than origin, substitute the name.

In the future, it's a good idea to not modify code on the master branch but keep master synced with upstream instead and use a different branch for PRs. See this link for more info:
https://contribute.jquery.org/commits-and-pull-requests/#never-commit-on-master

This is for the future sake only, let's keep this PR as it is as you can't change the source branch when the PR is open.

@gaohuia You can see that jQuery Slim tests failed on your PR (see the Travis link). Your unit test should be moved to unit/ajax.js where tests related to the ajax module should lie. Then that test will be excluded for the Slim build & it should pass again.

Also, remember about #4563 (comment) - we still need to get the tests to succeed in IE, Edge & Safari.

Hi @mgol I didn't see any failed tests in safari 13, can you try again?

@gaohuia Yes, Safari 13 is still failing. Note that Travis only runs tests on Chrome & Firefox, you need to test on the other browsers manually.

See e.g. Safari 13:

and Edge 18:

Hmm, the above test results were achieved in our PHP setup, the one that runs on our TestSwarm as well: http://swarm.jquery.org/project/jquery

When I run it on the Karma setup, by running grunt karma:chrome-debug, opening http://localhost:9876 in Safari & clicking "DEBUG", all tests pass.

However, in Chrome & Firefox tests pass in both modes.

I figured out the issue. Karma runs on http://localhost:9876 so a replacement of localhost to 127.0.0.1 worked fine there. However, on my local PHP setup I'm relying on virtual hosts so the page runs on http://jquery.l so the replacement failed and the loaded script was, in effect, using the same domain. Apparently, in Chrome & Firefox that works but Safari 13 & Edge 18 just don't execute the script.

Ultimately, we cannot rely on the URL where the tests are loaded to be localhost. On our TestSwarm, for example, tests are loaded via URLs like:
http://builds.jenkins.jquery.com/jquery/ff2819911da6cbbed5ee42c35d695240f06e65e3/test/index.html
Replacing it via an IP won't work.

We need to remove the replacement of localhost to 127.0.0.1 from the test. (This part is out of date, see my later comments) The mere inclusion of the crossorigin attribute makes the script loaded with the Origin header so the current test checking whether corsCallback was invoked with true would fail without current source changes; that may serve as some kind of a check. Unfortunately, if we cut out the Access-Control-Allow-Methods & Access-Control-Allow-Origin the test still passes; I'm not sure if there's a way around that, though, unfortunately.

@mgol can you tell me how to run the karma tests with the real mock.php (I mean run it with php)? I added the same logic to "mock.php", but just not sure if it works fine.

@gaohuia PHP tests are not run via Karma. To have all tests passing, you need to have Apache or nginx configured with PHP and open /test/?hidepassed in a browser, tests will run.

If this is too much, you can run a quick static PHP server in the jQuery directory:

php -S 0.0.0.0:7001

and then open http://localhost:7001/test/?hidepassed. Note that with this basic setup some tests will fail as PHP can only handle one request at a time and some tests depend on being able to run requests in parallel. But it might be enough for your purposes.

Thanks @mgol , i have nginx+fpm locally. the mock.php seems working good.

Landed, thanks!