Event: Only attach events to objects that accept data - for real #4558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, this does go back a ways! |
dmethvin
approved these changes
Dec 3, 2019
gibson042
approved these changes
Dec 9, 2019
gibson042
reviewed
Dec 9, 2019
test/unit/event.js
Outdated
| QUnit.test( ".on('focus', fn) on a text node doesn't throw", function( assert ) { | ||
| assert.expect( 1 ); | ||
|
|
||
| jQuery( "<div></div>text<span></span>" ) |
There was a problem hiding this comment.
I'd prefer something more obvious here such as jQuery( document.createTextNode("text") ), but this works as long as the behavior doesn't change (do we test that, though?).
There was a problem hiding this comment.
@gibson042 Your suggestion looks good to me. What do you mean by "as long as the behavior doesn't change", though? What behavior?
There was a check in jQuery.event.add that was supposed to make it a noop for objects that don't accept data like text or comment nodes. The problem was the check was incorrect: it assumed `dataPriv.get( elem )` returns a falsy value for an `elem` that doesn't accept data but that's not the case - we get an empty object then. The check was changed to use `acceptData` directly. Fixes jquerygh-4397
mgol
added a commit
that referenced
this pull request
Dec 9, 2019
There was a check in jQuery.event.add that was supposed to make it a noop for objects that don't accept data like text or comment nodes. The problem was the check was incorrect: it assumed `dataPriv.get( elem )` returns a falsy value for an `elem` that doesn't accept data but that's not the case - we get an empty object then. The check was changed to use `acceptData` directly. (cherry picked from d5c505e) Fixes gh-4397 Closes gh-4558
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a check in jQuery.event.add that was supposed to make it a noop
for objects that don't accept data like text or comment nodes. The problem was
the check was incorrect: it assumed
dataPriv.get( elem )returns a falsyvalue for an
elemthat doesn't accept data but that's not the case - we getan empty object then. The check was changed to use
acceptDatadirectly.Fixes gh-4397
It's funny that this has been the behavior for at least the past few years so this code has been wrong for a long time. 😱
We'll also need to CP that to
3.x-stable+2 bytes
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com