Selector: Use shallow document comparisons in uniqueSort #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in jquerygh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Those changes have landed in Sizzle in jquery/sizzle#459. Fixes jquerygh-4441 Closes jquerygh-4471 Ref jquery/sizzle#459
timmywil
approved these changes
Oct 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IE/Edge sometimes crash when comparing documents between frames using the strict
equality operator (
===&!==). Funnily enough, shallow comparisons(
==&!=) work without crashing.The change to shallow comparisons in
src/selector.jswas done in gh-4471 butrelevant changes in
src/selector/uniqueSort.jswere missed. Those changeshave landed in Sizzle in jquery/sizzle#459.
+1 byte
Fixes gh-4441
Ref gh-4471
Ref jquery/sizzle#459
Checklist