Manipulation:Selector: Use the nodeName util where possible to save size #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmethvin
approved these changes
Oct 8, 2019
|
|
||
| TAG: function( nodeNameSelector ) { | ||
| var nodeName = nodeNameSelector.replace( runescape, funescape ).toLowerCase(); | ||
| var expectedNodeName = nodeNameSelector.replace( runescape, funescape ).toLowerCase(); |
Member
There was a problem hiding this comment.
I thought it might save a bit more to name this nodeNameExpected but it was the same. One day I will understand gzip.
Member
Author
There was a problem hiding this comment.
@dmethvin Minification happens before gzip so source variable names are irrelevant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the
nodeNameutil where possible to save size.-20 bytes
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com