Skip to content

CSS: Workaround buggy getComputedStyle on table rows in IE/Edge #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Oct 14, 2019
Merged

CSS: Workaround buggy getComputedStyle on table rows in IE/Edge #4503

mgol merged 1 commit into from
Oct 14, 2019

Conversation

@mgol
Copy link
Member

@mgol mgol commented Oct 7, 2019

Summary

Workaround buggy getComputedStyle on table rows in IE/Edge.

Fixes gh-4490

Checklist

@mgol mgol added this to the 3.5.0 milestone Oct 7, 2019
@mgol mgol mentioned this pull request Oct 7, 2019
Closed
@mgol mgol force-pushed the ie-tr-height-3.x branch from 0878d09 to aaa274d Compare October 8, 2019 23:00
@mgol
Copy link
Member Author

mgol commented Oct 8, 2019

+107 bytes

timmywil
timmywil approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bytes 😭

@mgol mgol force-pushed the ie-tr-height-3.x branch from aaa274d to 0478c5c Compare October 9, 2019 16:31
@mgol mgol mentioned this pull request Oct 9, 2019
Merged
3 tasks
@mgol
Copy link
Member Author

mgol commented Oct 9, 2019

@timmywil What's +107 bytes compared to +147 bytes for the master version... #4506

@mgol mgol force-pushed the ie-tr-height-3.x branch from 0478c5c to 78a80d2 Compare October 9, 2019 18:17
@timmywil
Copy link
Member

timmywil commented Oct 10, 2019

😱

@mgol mgol removed the Needs review label Oct 14, 2019
@mgol mgol merged commit 6d31477 into jquery:3.x-stable Oct 14, 2019
@mgol mgol deleted the ie-tr-height-3.x branch October 14, 2019 16:34
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

No one assigned

Labels

CSS

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @timmywil