Skip to content

Build: Stop copying src/core.js to dist on release #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Build: Stop copying src/core.js to dist on release #4492

merged 1 commit into from
Oct 4, 2019

Conversation

mgol
Copy link
Member

@mgol mgol commented Sep 26, 2019

Summary

File src/core.js has started erroneously being copied to dist/ in gh-2981.

Fixes gh-4489
Ref gh-2979
Ref gh-2981

Checklist

Sorry, something went wrong.

@mgol mgol added the Build label Sep 26, 2019
@mgol mgol mentioned this pull request Sep 26, 2019
Closed
@mgol
Copy link
Member Author

mgol commented Sep 26, 2019

This needs to be CP'd to 3.x-stable as well so that 3.5.0 doesn't include dist/core.js.

@mgol mgol self-assigned this Sep 26, 2019
timmywil
timmywil previously approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a while ago, but I think this file was included so that the version number would get written to the file, but it was supposed to remain in the src folder. It looks like that didn't happen. I'm fine with just ignoring that.

@mgol mgol dismissed timmywil’s stale review October 2, 2019 21:31

Clearing the review as the PR's implementation is still wrong & needs further work

@mgol mgol removed the Needs review label Oct 2, 2019
@mgol
Build: Stop copying src/core.js to dist on release
8b86629 
File `src/core.js` has started erroneously being copied to `dist/` in jquerygh-2981.

Fixes jquerygh-4489
Ref jquerygh-2979
Ref jquerygh-2981
@mgol mgol force-pushed the dist-no-core-js branch from 42e47d9 to 8b86629 Compare October 2, 2019 22:48
@mgol mgol requested a review from timmywil October 2, 2019 23:06
@mgol
Copy link
Member Author

mgol commented Oct 2, 2019

@timmywil Ready for another review.

It looks like it should work now, I did a test release & that was the generated commit for jquery-dist: mgol/jquery-dist@05edfb5. No dist/core.js and src/core.js did get a version replaced.

timmywil
timmywil approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol removed the Needs review label Oct 4, 2019
@mgol mgol added this to the 4.0.0 milestone Oct 4, 2019
@mgol mgol merged commit 9a4d980 into jquery:master Oct 4, 2019
@mgol mgol deleted the dist-no-core-js branch October 4, 2019 14:13
mgol added a commit that referenced this pull request Oct 4, 2019
@mgol
Build: Stop copying src/core.js to dist on release
279d2e9 
File `src/core.js` has started erroneously being copied to `dist/` in gh-2981.

Fixes gh-4489
Closes gh-4492
Ref gh-2979
Ref gh-2981

(cherry picked from commit 9a4d980)
@mgol mgol modified the milestones: 4.0.0, 3.5.0 Oct 4, 2019
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Oct 4, 2019
Merged
4 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timmywil timmywil

Assignees

@mgol mgol

Labels
Build
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Broken core.js file is dist packages
2 participants
@mgol @timmywil