Skip to content

Core: Implement .even() & .odd() to replace POS :even & :odd #4485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2019
Merged

Core: Implement .even() & .odd() to replace POS :even & :odd #4485

merged 3 commits into from
Sep 24, 2019

Conversation

mgol
Copy link
Member

@mgol mgol commented Sep 16, 2019

Summary

Implement .even() & .odd() to replace POS :even & :odd. The current version adds 28 bytes; it'd be slightly smaller (+25 bytes) to rely on .filter() but that'd make core depend on traversing/findFilter.

Checklist

Sorry, something went wrong.

@mgol
Copy link
Member Author

mgol commented Sep 16, 2019 •
edited
Loading

@jquery/core If we want to make the migration away from POS selectors easier, it might be worth releasing the next jQuery as 3.5.0 instead of 3.4.2 with .odd()/.even() implemented. Thoughts?

@mgol mgol mentioned this pull request Sep 16, 2019
Open
timmywil
timmywil approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and yes 3.5.

@mgol mgol added this to the 3.4.2 milestone Sep 23, 2019
@dmethvin
Copy link
Member

This definitely will make migration easier.

@mgol mgol removed the Needs review label Sep 24, 2019
@mgol mgol merged commit 78420d4 into jquery:master Sep 24, 2019
@mgol mgol deleted the even-odd branch September 24, 2019 00:04
mgol added a commit that referenced this pull request Sep 24, 2019
@mgol
Core: Implement .even() & .odd() to replace POS :even & :odd
409cbda 
`:even` & `:odd` are deprecated since jQuery 3.4.0 & will be removed in 4.0.0.
The new `even()` & `odd()` methods will make the migration easier.

Closes gh-4485

(cherry picked from commit 78420d4)
@lock lock bot locked as resolved and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timmywil timmywil

Assignees
No one assigned
Labels
Core
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mgol @dmethvin @timmywil