Traversing: Fix contents() on <object>s with children in IE
#4390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
The original fix didn't account for the fact that in IE `<object>` elements with no `data` attribute have an object `contentDocument`. The fix leverages the fact that this special object has a null prototype. Ref jquerygh-4384 Ref jquerygh-4385
Member
Author
|
|
patocallaghan
added a commit
to intercom/jquery
that referenced
this pull request
May 7, 2019
patocallaghan
added a commit
to intercom/jquery
that referenced
this pull request
May 7, 2019
Member
Author
|
This unbreaks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original fix didn't account for the fact that in IE
<object>elementswith no
dataattribute have an objectcontentDocument. The fix leveragesthe fact that this special object has a null prototype.
Ref gh-4384
Ref gh-4385
+9 bytes. I tested it in IE this time.
Checklist
New tests have been added to show the fix or feature worksExisting tests were failing before this PR.If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com