Data: Separate data & css/effects camelCase implementations #4365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmethvin
approved these changes
Apr 18, 2019
Member
dmethvin
left a comment
dmethvin
left a comment
There was a problem hiding this comment.
Has this been a problem in practice? For complete consistency I'm okay with it and +2 bytes is a small price to pay.
gibson042
approved these changes
Apr 22, 2019
The camelCase implementation used by the data module no longer turns `-ms-foo` into `msFoo` but to `MsFoo` now. This is because `data` is supposed to be a generic utility not specifically bound to CSS use cases. Fixes jquerygh-3355
mgol
force-pushed
the
camelCase-separation
branch
from
821d23f to
fe1db84
Compare
timmywil
approved these changes
Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The camelCase implementation used by the data module no longer turns
-ms-foointo
msFoobut toMsFoonow. This is becausedatais supposed to bea generic utility not specifically bound to CSS use cases.
Fixes gh-3355
+2bytesChecklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com(this behavior was never documented AFAIK)