Skip to content

Build: Fix unresolved jQuery reference in finalPropName #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgol merged 1 commit into from
Apr 17, 2019
Merged

Build: Fix unresolved jQuery reference in finalPropName #4361

mgol merged 1 commit into from
Apr 17, 2019

Conversation

@mgol
Copy link
Member

@mgol mgol commented Apr 17, 2019

Summary

Also, prevent further similar breakages by changing our ESLint configuration
to disallow relying on a global jQuery object in AMD modules.

Fixes gh-4358

Checklist

@mgol
Build: Fix unresolved jQuery reference in finalPropName
d7298c1 
Also, prevent further similar breakages by changing our ESLint configuration
to disallow relying on a global jQuery object in AMD modules.

Fixes jquerygh-4358
@mgol mgol added the Build label Apr 17, 2019
@mgol mgol added this to the 3.4.1 milestone Apr 17, 2019
@mgol mgol self-assigned this Apr 17, 2019
@mgol mgol mentioned this pull request Apr 17, 2019
Closed
timmywil
timmywil approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad we could add this to lint.

@mgol
Copy link
Member Author

mgol commented Apr 17, 2019

This is quite small & I need it for another PR so I'll just land it.

@mgol mgol removed the Needs review label Apr 17, 2019
@mgol mgol merged commit 8740305 into jquery:master Apr 17, 2019
@mgol mgol deleted the amd-fix branch April 17, 2019 17:56
mgol added a commit that referenced this pull request Apr 17, 2019
@mgol
Build: Fix unresolved jQuery reference in finalPropName
0d4af52 
Also, prevent further similar breakages by changing our ESLint configuration
to disallow relying on a global jQuery object in AMD modules.

(cherry-picked from 8740305)

Fixes gh-4358
Closes gh-4361
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Apr 20, 2019
Merged
4 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timmywil timmywil timmywil approved these changes

Assignees

@mgol mgol

Labels

Build

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

jQuery 3.4 errors with src directory webpack alias

2 participants

@mgol @timmywil