Skip to content

Conversation

@gibson042
Copy link
Member

One commit to restore the test, one to fix it, and the rest to reduce size.

Summary

Ref 669f720

  • Restore the no-duplication logic in focusin/focusout testing
  • Reduce size
   raw     gz Sizes
279073  82883 dist/jquery.js
 88068  30594 dist/jquery.min.js

   raw     gz Compared to master @ 669f720edc4f557dfef986db747c09ebfaa16ef5
   +89   +209 dist/jquery.js
  -113    -28 dist/jquery.min.js

Checklist

@mgol mgol added the Event label Mar 22, 2019
@mgol mgol added this to the 3.4.0 milestone Mar 22, 2019
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Just two comments.

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mgol
Copy link
Member

mgol commented Mar 22, 2019

@timmywil Let's get it landed before 3.4.0.

@mgol mgol added the Blocker label Mar 25, 2019
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgol mgol removed the Needs review label Mar 25, 2019
@mgol mgol merged commit fe5f04d into jquery:master Mar 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants