Manipulation: Only evaluate HTTP-successful script src #4243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
approved these changes
Dec 3, 2018
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
LGTM. I'd prefer fixing dataType: "script" handling so that it doesn't evaluate unsuccessful scripts and I'd like to evaluate that for jQuery 4.0. For jQuery 3.4 this change looks good.
Member
|
@gibson042 I merged the PR but it broke tests in IE 9-11 & iOS 7-9: http://swarm.jquery.org/job/8524 |
gibson042
added a commit
to gibson042/jquery
that referenced
this pull request
Dec 13, 2018
IE and iOS <10 XHR transport does not succeed on data: URIs Ref jquerygh-4243 Ref jquerygh-4126
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-4126
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com