CSS: Don't auto-append "px" to CSS variables #4064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
May 1, 2018
| @@ -246,7 +246,9 @@ jQuery.extend( { | |||
| } | |||
|
|
|||
| // If a number was passed in, add the unit (except for certain CSS properties) | |||
| if ( type === "number" ) { | |||
| // The isCustomProp check can be removed in jQuery 4.0 when we only auto-append | |||
There was a problem hiding this comment.
Is there a url we can reference for this statement/plan?
There was a problem hiding this comment.
Once this PR lands I'll rebase #4055 and add a removal of this part there so I just need to remember about it until that moment. :)
There was a problem hiding this comment.
I landed this PR & rebased PR #4055, reverting this fix there.
gibson042
approved these changes
May 7, 2018
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-4063
Summary
Fixes gh-4063
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com