Core: deprecate jQuery.isNumeric #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
2960
branch
2 times, most recently
from
d58ba3d to
4e5ba83
Compare
Member
|
Docs ticket is jquery/api.jquery.com#949 |
Contributor
Author
|
Migrate ticket: jquery/jquery-migrate#280 |
mgol
requested changes
Jan 5, 2018
test/unit/deprecated.js
Outdated
| assert.ok( !jQuery.isWindow( function() {} ), "function" ); | ||
| } ); | ||
|
|
||
| QUnit.test( "core", function( assert ) { |
Member
There was a problem hiding this comment.
This test is not needed (same rationale as in your other PR).
jbedard
force-pushed
the
2960
branch
5 times, most recently
from
47cf242 to
3518556
Compare
jbedard
force-pushed
the
2960
branch
11 times, most recently
from
b100403 to
87d8062
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-2960
Summary
Removes all usage of
jQuery.isNumeric(just tests) and replaces with!isNaN(pareseFloat(...)). MovesjQuery.isNumericto deprecated.js.Checklist