Skip to content

Conversation

@gibson042
Copy link
Member

Summary

Recognize that offsetWidth and offsetHeight report CSS border-box dimensions, and (stealing gh-3602 from @timmywil) use them when Android lies about the size of inline elements.

Fixes gh-3698
Fixes gh-3602

Checklist

Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gibson042 gibson042 merged commit a495784 into jquery:master Jul 31, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
@mgol
Copy link
Member

mgol commented Oct 23, 2019

The test added here started failing in Firefox 70, see issue #4529.

@mgol mgol added this to the 3.3.0 milestone Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

outerHeight() differs between chrome and IE11 Regression: Inline width returns 0 on Android 4

5 participants