9d822bc1c13dd3393b418210a99537c22c06f2c3 followup #3496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibson042, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gnarf, @markelog and @dmethvin to be potential reviewers. |
markelog
reviewed
Jan 13, 2017
src/effects.js
Outdated
| animation.opts.start.call( elem, animation ); | ||
| } | ||
|
|
||
| // attach callbacks from options |
Member
There was a problem hiding this comment.
Stupid nitpick: probably better to start with uppercase 'attach' -> 'Attach', I know it was like that before and linter didn't catch that for some reason...
markelog
reviewed
Jan 13, 2017
Member
markelog
left a comment
markelog
left a comment
There was a problem hiding this comment.
Looks like this commit head a little long, no?
Member
|
This is awesome, nicely done, well, as always! :) |
markelog
approved these changes
Jan 13, 2017
Member
|
Any chance this affects #3434? |
Member
Author
|
I wouldn't think so, but it's possible. #3434 is unexpected. |
timmywil
approved these changes
Jan 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9d822bc failed an effects test (cf. #3470 (comment) ), but it turns out that things were already broken in subtle ways when animations spawn each other:
Each fix revealed the next flaw, so all are addressed here in order to resolve the current CI failure. I should probably make real issues so they can be resolved by this PR.