Tests: Update the loader so test pages always get jQuery #3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibson042, thanks for your PR! By analyzing the history of the files in this pull request, we identified @timmywil and @markelog to be potential reviewers. |
Member
|
Why is this needed? |
Member
Author
|
It's not needed, but being able to open the iframe-test pages in a browser tab and make the same jQuery calls as their respective tests is definitely a worthwhile convenience, especially when we can get it without breaking anything. But absent this fix, opening e.g. test/data/offset/absolute.html generates Line 11 in a8816ca |
Member
|
Cool! Could you put that explanation in the commit? :) |
Pages used for iframe tests will now successfully load jQuery, even when opened directly in the browser.
gibson042
force-pushed
the
2017-01-test-suite-meta-loader
branch
from
00e1e17 to
dc41a56
Compare
Member
Author
|
Done. |
markelog
approved these changes
Jan 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helped work on gh-3487.