Build: Drop support for building on Node.js 0.12 #3478
Merged
+11
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgol, thanks for your PR! By analyzing the history of the files in this pull request, we identified @markelog, @timmywil and @mikesherov to be potential reviewers. |
mgol
force-pushed
the
node0.12-eol
branch
2 times, most recently
from
bbeb533 to
9b3cdd2
Compare
Member
|
Yey! We shouldn't have any issues with jenkins right? |
Member
Author
|
I switched our project on Jenkins to Node 4 a while ago. :) I should switch it to Node 6 now since Node 4 will get into Maintenance Mode in 4 months. |
Member
|
Cool |
markelog
approved these changes
Dec 30, 2016
Node.js 0.12 is no longer supported by upstream. So far we had to keep a workaround that would skip running ESLint there (or even load its task) as it no longer supports Node.js <4; the same applied to Node smoke tests as jsdom has also dropped support for those old Node versions. Those workarounds have been removed now. Ref 030191a Closes jquerygh-3478
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Node.js 0.12 is no longer supported by upstream. So far we had to keep
a workaround that would skip running ESLint there (or even load its task)
as it no longer supports Node.js <4; the same applied to Node smoke tests
as jsdom has also dropped support for those old Node versions. Those
workarounds have been removed now.
Ref 030191a
Checklist
Mark an
[x]for completed items, if you're not sure leave them unchecked and we can assist.Thanks! Bots and humans will be around shortly to check it out.