Tests: Added tests for colon separated tag names #3473
Conversation
|
|
|
@broder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @markelog, @LeonardoBraga and @jeresig to be potential reviewers. |
test/unit/core.js
Outdated
| QUnit.test( "jQuery(symbol separated elements)", function( assert ) { | ||
| assert.expect( 34 ); | ||
|
|
||
| jQuery.each( "- :".split( " " ), function( i, symbol ) { |
There was a problem hiding this comment.
This looks unnecessarily complex, just [ "-", ":" ] will do.
test/unit/core.js
Outdated
|
|
||
| jQuery.each( "- :".split( " " ), function( i, symbol ) { | ||
| jQuery.each( "thead tbody tfoot colgroup caption tr th td".split( " " ), function( k, element ) { | ||
| var j = jQuery( "<" + element + symbol + "test></" + element + symbol + "test>" ); |
There was a problem hiding this comment.
And this is getting even harder to read. Let's just introduce a tagName variable.
test/unit/core.js
Outdated
| var j = jQuery( "<" + name + "-d></" + name + "-d>" ); | ||
| assert.ok( j[ 0 ], "Create a tag-hyphenated elements" ); | ||
| assert.ok( jQuery.nodeName( j[ 0 ], name.toUpperCase() + "-D" ), "Tag-hyphenated element has expected node name" ); | ||
| QUnit.test( "jQuery(symbol separated elements)", function( assert ) { |
There was a problem hiding this comment.
More accurately, "jQuery(element with non-alphanumeric name)".
test/unit/core.js
Outdated
| var tagName = tag + symbol + "test"; | ||
| var el = jQuery( "<" + tagName + "></" + tagName + ">" ); | ||
| assert.ok( el[ 0 ], "Create a " + tagName + " element" ); | ||
| assert.ok( jQuery.nodeName( el[ 0 ], tagName.toUpperCase() ), tagName + " element has expected node name" ); |
There was a problem hiding this comment.
This looks good, but I have one last request: can you keep the lines to a maximum of 100 characters by introducing line breaks before the last argument to the long assert.oks and the inner jQuery.each?
|
Thanks! |
4 participants
Summary
This should cover #2006. Are there any other symbols we would specifically like to test?
Checklist