Offset: Eliminate little-used internal function #3456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibson042, thanks for your PR! By analyzing the history of the files in this pull request, we identified @timmywil, @jbedard and @markelog to be potential reviewers. |
mgol
approved these changes
Dec 16, 2016
markelog
reviewed
Dec 19, 2016
src/offset.js
Outdated
| var win = getWindow( elem ); | ||
|
|
||
| // Coalesce documents and windows | ||
| var win = jQuery.isWindow( elem ) ? elem : elem.nodeType === 9 && elem.defaultView; |
Member
There was a problem hiding this comment.
Maybe if..else instead of ternary... please 😇
markelog
reviewed
Dec 19, 2016
src/offset.js
Outdated
| if ( jQuery.isWindow( elem ) ) { | ||
| win = elem; | ||
| } else { | ||
| win = elem.nodeType === 9 && elem.defaultView; |
mgol
reviewed
Dec 19, 2016
src/offset.js
Outdated
| if ( jQuery.isWindow( elem ) ) { | ||
| win = elem; | ||
| } else { | ||
| win = elem.nodeType === 9 && elem.defaultView; |
Member
There was a problem hiding this comment.
Maybe the nodeType check could be moved into the else? That would make it even less hacky.
mgol
approved these changes
Dec 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-3449