Deferred: Stop inventing jQuery.when() resolution values #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibson042, thanks for your PR! By analyzing the history of the files in this pull request, we identified @markelog, @jaubourg and @dmethvin to be potential reviewers. |
mgol
requested changes
Dec 13, 2016
| // Support: Android 4.0 only | ||
| // Strict mode functions invoked without .call/.apply get global-object context | ||
| resolve.call( undefined, value ); | ||
| resolve.apply( undefined, [ value ].slice( noValue ) ); |
Member
There was a problem hiding this comment.
This looks like "clever code", this passing booleans to slice. I guess that's done to reduce size (a regular if-else would be larger) but at least an explanatory comment would be useful.
Member
Author
There was a problem hiding this comment.
Good point, and correct. Updated.
mgol
reviewed
Dec 13, 2016
| // Support: Android 4.0 only | ||
| // Strict mode functions invoked without .call/.apply get global-object context | ||
| reject.call( undefined, value ); | ||
| reject.apply( undefined, [ value ] ); |
Member
There was a problem hiding this comment.
What's the reason for this change?
Member
Author
There was a problem hiding this comment.
Consistency with the preceding block, which also effects size reduction (reuse of the .apply( undefined, [ value ]… pattern is good for compression).
mgol
approved these changes
Dec 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-3442