Skip to content

Conversation

@alisianoi
Copy link

@alisianoi alisianoi commented Dec 7, 2016

Summary

@mgol recently reported in jzaefferer/commitplease#91 that commitplease failed with valid commit messages. That happened because the regular expressions configured here in package.json triggered for any word with a prefix "ref", like reformat or refactor. This PR fixes those regular expressions.

Checklist

Mark an [x] for completed items, if you're not sure leave them unchecked and we can assist.

* [x] Grunt build and unit tests pass locally with these changes~~~
~~~* [ ] If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com~~~

Thanks! Bots and humans will be around shortly to check it out.

Commit messages used to fail the style check if they contained a word
starting with "ref", like reformat or reference, in their message body.

Refs jzaefferer/commitplease#91

Commit messages used to fail the style check if they contained a word
starting with "ref", like reformat or reference, in their message body.

Refs jzaefferer/commitplease#91
@mention-bot
Copy link

@all3fox, thanks for your PR! By analyzing the history of the files in this pull request, we identified @timmywil, @gibson042 and @mgol to be potential reviewers.

@jsf-clabot
Copy link

jsf-clabot commented Dec 7, 2016

CLA assistant check
All committers have signed the CLA.

@timmywil timmywil added this to the 3.2.0 milestone Jan 9, 2017
@timmywil timmywil merged commit 25c6a0a into jquery:master Jan 9, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants