Skip to content

Build: jQuery Foundation -> JS Foundation #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timmywil wants to merge 1 commit into from
Closed

Build: jQuery Foundation -> JS Foundation #3414

timmywil wants to merge 1 commit into from

Conversation

@timmywil
Copy link
Member

@timmywil timmywil commented Nov 28, 2016

  • I think the contribute link only relates to projects within the jQuery organization (this is as opposed to linking to contribute.jquery.org and saying all JS Foundation projects).
  • I want to keep the jQuery license link rather than linking to js.foundation, because licenses are per project and not global to the foundation.

@mention-bot
Copy link

mention-bot commented Nov 28, 2016

@timmywil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @agcolom, @jdufresne and @rwaldron to be potential reviewers.

@timmywil
Copy link
Member Author

timmywil commented Nov 28, 2016

@kborchers

@kborchers
Copy link
Member

kborchers commented Nov 28, 2016

Looks great to me. Also agree with the foundation vs org changes. We need to make that clearer on jquery.org and clean that up too but just haven't had time to even clearly lay out an issue for someone else to do it.

Thanks!

@timmywil timmywil closed this in 7fbab88 Dec 5, 2016
@timmywil timmywil deleted the js-foundation branch December 5, 2016 16:55
@lock lock bot locked as resolved and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timmywil @mention-bot @kborchers