Add missing Qunit script #3285
Closed
Add missing Qunit script #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevemao
force-pushed
the
missing-qunit
branch
from
37338b9 to
0c44333
Compare
| #output { background-color: green } | ||
| #expectedOutput { background-color: green } | ||
| </style> | ||
| <script src="../external/qunit/qunit.js"></script> |
Member
There was a problem hiding this comment.
This is pointless, since nothing on the page attempts to access QUnit. But the page itself is totally disconnected from unit testing AFAICT. However, that need not be the case... @stevemao, would you be willing to make the necessary changes to invoke readywait.html as an iframe test?
Contributor
Author
There was a problem hiding this comment.
Sounds like a better solution :)
Member
|
Since this PR got stale, I'll close it. But we'd gladly accept a different PR that invokes readywait.html in an iframe test. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.