Build: Skip running ESLint on Node.js 0.x #3225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgol, thanks for your PR! By analyzing the annotation information on this pull request, we identified @markelog, @sindresorhus and @jha-naman to be potential reviewers |
|
|
||
| var fs = require( "fs" ), | ||
| gzip = require( "gzip-js" ), | ||
| oldNode = /^v0\./.test( process.version ); |
Member
There was a problem hiding this comment.
maybe you could encapsulate it in runIfNewNode method?
Member
Author
There was a problem hiding this comment.
I need this variable outside of this function as well (see the load-grunt-tasks line).
mgol
force-pushed
the
skip-eslint-on-old-node
branch
from
517651f to
067122d
Compare
Member
Author
|
This should be good to go. Any objections to land? |
ESLint 3.0 drops support for Node.js older than 4.x. To be able to update to this version and yet not block our contributors from building jQuery on older Node.js (at least until it's supported by upstream) this commit makes ESLint skipped on older Node; a proper message is displayed then. Fixes jquerygh-3222
ESLint is now skipped in Node older than 4.x so we're safe. Refs jquerygh-3222
mgol
force-pushed
the
skip-eslint-on-old-node
branch
from
067122d to
96966c0
Compare
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR makes it possible to use the new ESLint 3.x that's incompatible with Node.js older than 4.x but at the same time allows to build jQuery in an older Node. The tasks using problematic modules (like ESLint & jsdom) are skipped there.
Checklist
Mark an
[x]for completed items, if you're not sure leave them unchecked and we can assist.New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.comThanks! Bots and humans will be around shortly to check it out.
Fixes gh-3222
cc @markelog