By analyzing the blame information on this pull request, we identified @gibson042, @mgol and @Krinkle to be potential reviewers

Would like to land this ASAP, since if other commits would be presented to the master it would be harder to keep this up to date.

If there is no objections will land this tomorrow

Will you squash it before landing? Sometimes landing many commits makes sense but the first one doesn't compile to me so it'd be bad to land it without squashing on master.

Will you squash it before landing?

Not sure, would like to keep Tests: and Build: commits separate, if it will be tricky, i wouldn't want to risk it

Will you squash it before landing?

Not sure, would like keep Tests: and Build: commits separate, if it will be tricky, i wouldn't want to risk it

I'm mostly asking because of Git rebase. I sometimes use it to narrow down which commit introduced a particular regression, via the cycle of npm it, testing the issue and git bisect good or git bisect bad and if a commit that doesn't compile is landed it makes it harder to bisect.

If it's hard to squash, maybe you could edit the first commit to disable running eslint on grunt or grunt test there (e.g. via commenting out its entry in various tasks) and restore at the end? That would make all commits compile at the cost of having 3 commits with temporarily disabled linting which doesn't sound like a big issue.

@markelog OK, I wrote some comments, the most important to me are those related to the browser env in .eslintrc and linting dist/jquery.js.

It looks good overall, though, thanks for this work! 👏

If it's hard to squash, maybe you could edit the first commit to disable running eslint on grunt or grunt test there (e.g. via commenting out its entry in various tasks) and restore at the end?

Okay, will do.

Will fix issues you pointed out and if no one has anything else, will land this tomorrow

@markelog I commented about a few things in the first commit in the preset repo but nothing terribly important.