Release: copy sizzle to external folder in dist, remove files during dist copy #3116
Conversation
|
By analyzing the blame information on this pull request, we identified @markelog, @scottgonzalez and @bperel to be potential reviewers |
timmywil
changed the title
| i = rmIgnore.length; | ||
|
|
||
| while ( --i ) { | ||
| rmIgnore[ i ] = Release.dir.dist + "/" + rmIgnore[ i ]; |
There was a problem hiding this comment.
Why not
rmIgnore = rmIgnore.map( function( dirname ) {
return Release.dir.dist + "/" + dirname;
} );? The i variable would be unnecessary.
There was a problem hiding this comment.
Do all the nodes we support have map?
There was a problem hiding this comment.
Ok, 0.10 has it. I thought it didn't for some reason. I'll make the switch.
There was a problem hiding this comment.
Keep in mind that this code will be used by the maintainers only :)
There was a problem hiding this comment.
Yeah, Node.js has been ES5-compatible for a long time now. :)
|
From what I see part of it has already partially landed on |
|
Hmm. That's odd. I don't remember pushing that. |
|
@mgol My mistake. I must have had the commit on that branch locally for a minute. It's been reverted until this PR is merged. |
Summary
Fixes a couple release issues. Tested with jquery-release.
Fixes gh-3094
Fixes gh-2945
Checklist
[ ] New tests have been added to show the fix or feature works[ ] If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com