Event: Add touch event properties, eliminates need for a plugin #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jquery#3104 See https://github.com/aarongloege/jquery.touchHooks Other properties are already present thanks to mouse events.
|
By analyzing the blame information on this pull request, we identified @gibson042, @jeresig and @mgol to be potential reviewers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3104
See https://github.com/aarongloege/jquery.touchHooks
Other properties are already present thanks to mouse events. I am going to assume this doesn't need tests since we've proven elsewhere that things are copied as long as they're spelled right.
Does need a docs update, I'll open a ticket when it gets the thumbs up.
Checklist
Mark an
[x]for completed items, if you're not sure leave them unchecked and we can assist.New tests have been added to show the fix or feature worksThanks! Bots and humans will be around shortly to check it out.