Event: Remove pageX/pageY fill for event object #3106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jquerygh-3092 IE8 was the last major browser missing these.
|
By analyzing the blame information on this pull request, we identified @jeresig, @gibson042 and @mgol to be potential reviewers |
|
OBTW this is |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-3092
IE8 was the last major browser missing these. Support elsewhere looks good, according to http://www.quirksmode.org/mobile/tableViewport.html . Our existing unit tests for them are pretty sparse but they did catch when the properties were left off the list. Creating fake events with predefined pageX/Y won't help our ability to determine whether the browser values are correct. Docs issue isn't needed because we will still be copying them.
Checklist
Mark an
[x]for completed items, if you're not sure leave them unchecked and we can assist.New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.comThanks! Bots and humans will be around shortly to check it out.