Skip to content

Deferred: Make jQuery.when synchronous when possible #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gibson042 wants to merge 4 commits into from
Closed

Deferred: Make jQuery.when synchronous when possible #3105

gibson042 wants to merge 4 commits into from

Conversation

@gibson042
Copy link
Member

@gibson042 gibson042 commented May 5, 2016

Closes gh-3102
Fixes gh-3100

I'm ambivalent about this, but it doesn't cost much.

   raw     gz Sizes
264011  78513 dist/jquery.js
 86318  30014 dist/jquery.min.js

   raw     gz Compared to master @ 7f2ebd2c4dea186d7d981b939e6e2983a9d7f9c1
  +110    +22 dist/jquery.js
   +44    +17 dist/jquery.min.js

@mention-bot
Copy link

mention-bot commented May 5, 2016

By analyzing the blame information on this pull request, we identified @markelog, @jaubourg and @dmethvin to be potential reviewers

dmethvin
dmethvin reviewed May 5, 2016
View reviewed changes
test/unit/deferred.js
validate = function() {
assert.equal( when, "before" );
},
done = assert.async( 5 );
Copy link
Member

@dmethvin dmethvin May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget you can do this.

Copy link
Member

@timmywil timmywil May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't it require a QUnit update?

Copy link
Member Author

@gibson042 gibson042 May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've only had it since January. It was added in QUnit 1.20.

@dmethvin
Copy link
Member

dmethvin commented May 5, 2016

I'm okay with it. It actually simplifies the docs and upgrade guide I think?

@gibson042
Copy link
Member Author

gibson042 commented May 5, 2016

I think so, just by virtue of changing less.

@timmywil
Copy link
Member

timmywil commented May 5, 2016

I guess I'm okay with this.

@gibson042 gibson042 mentioned this pull request May 5, 2016
Closed
@timmywil timmywil mentioned this pull request May 9, 2016
Closed
@gibson042 gibson042 closed this in de71e97 May 9, 2016
@marcandre
Copy link

marcandre commented May 9, 2016

Great! Eager to run the spec suite of Parsley with this in. Thanks for the consideration and good discutions 😄

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gibson042 @mention-bot @dmethvin @timmywil @marcandre @jquerybot