Skip to content

Conversation

@ralinc
Copy link
Contributor

@ralinc ralinc commented Apr 29, 2016

Summary

The call to jQuery.trim can be removed since the subsequent match
will ignore leading and trailing spaces anyway. Fixes #3003.

Checklist

Mark an [x] for completed items, if you're not sure leave them unchecked and we can assist.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @farmdawgnation, @jaubourg and @gibson042 to be potential reviewers

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@ralinc ralinc force-pushed the remove-whitespace-trim branch from 07cb37c to bb374cd Compare April 29, 2016 19:21
As agreed in the issue, the call to jQuery.trim can be removed
since the subsequent match will ignore leading/trailing space anyway.

Fixes jquery#3003.
@ralinc ralinc force-pushed the remove-whitespace-trim branch from bb374cd to 833f444 Compare April 29, 2016 19:22
@dmethvin
Copy link
Member

The scope of this change is smaller than all of gh-3003 but it's a downpayment! Also worth taking a look at gh-3072 since the discussion there is related. Still I don't see anything blocking us landing this part now.

@ralinc
Copy link
Contributor Author

ralinc commented Apr 29, 2016

@dmethvin I can remove the "Fixes 3003" from the description if you want to merge this PR.

@gibson042 gibson042 closed this in 0bd98b1 Apr 29, 2016
@gibson042
Copy link
Member

Ticket reference updated and landed; thanks @ralinchimev!

@ralinc ralinc deleted the remove-whitespace-trim branch April 29, 2016 20:50
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Internal use of jQuery.trim erroneously strips too much

5 participants