Don't let .param() use jQuery.ajaxSettings.traditional #3081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jquerygh-3023 Since .param() no longer looks at this setting we need unit tests to ensure it is still honored by $.ajax().
dmethvin
changed the title
Member
|
Maybe we should add a test checking if Otherwise LGTM. |
Member
Author
|
Yes, that's a good test to do since I will be landing his commit separately from mine. Just added and pushed. |
Member
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR incorporates the changes in gh-3030 and adds unit tests to ensure no regressions in
$.ajax().Checklist
Mark an
[x]for completed items, if you're not sure leave them unchecked and we can assist.jquery/api.jquery.com#919