serialize: .param - don't use ajaxSettings.traditional as a default value #3030
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
sowcow
force-pushed
the
iss-3023-serialize-param-dont-use-ajaxsettings-traditional
branch
from
0449df5 to
c5c3860
Compare
|
This LGTM, can I land it before we do the beta? If so I want to make a note in the upgrade guide since it's a breaking change, even tho we documented it had changed as of 1.8 as #3023 mentioned. |
You mean rc? +1 from me, we should land it while we have a chance! |
|
|
||
| params = { "param1": null }; | ||
| assert.equal( jQuery.param( params, false ), "param1=", "Make sure that null params aren't traversed." ); |
There was a problem hiding this comment.
It's okay to leave the explicit false cases in here, right?
There was a problem hiding this comment.
I guess it depends on what provides more value here - explicitness, or tests that are closer to how it is expected to be used. Explicitness is related to better maintability in a way?
|
@sowcow will you be able to get to this soon? |
|
Don't land this PR as it is incorporated into gh-3081 and I'll just close this PR when that one lands. |
|
BTW, thanks for your help @sowcow! 🌟 |
(Fixes #3023)