Skip to content

Improve support properties computation #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markelog wants to merge 2 commits into from
Closed

Improve support properties computation #3021

markelog wants to merge 2 commits into from

Conversation

@markelog
Copy link
Member

@markelog markelog commented Mar 28, 2016

  • Remove div from the memory if it is not needed anymore
  • Make computeStyleTests method a singleton

@mention-bot
Copy link

mention-bot commented Mar 28, 2016

By analyzing the blame information on this pull request, we identified @mgol, @gibson042 and @timmywil to be potential reviewers

markelog added 2 commits March 28, 2016 16:16
@markelog
Build: add "Support" module to commitplease list
e8ff817
@markelog
Support: improve support properties computation
0465e69 
* Remove div from the memory if it is not needed anymore

* Make `computeStyleTests` method a singleton

Fixes jquerygh-3018
mgol
mgol reviewed Mar 28, 2016
View reviewed changes
src/css/support.js
var divStyle = window.getComputedStyle( div );
pixelPositionVal = divStyle.top !== "1%";

// Support: Android 4.0 - 4.3 only, Firefox <=3 - 44+
Copy link
Member

@mgol mgol Mar 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did ypu check Firefox 3? :)

Copy link
Member Author

@markelog markelog Mar 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you? Since you are the author of that comment :), i just moved it around

Copy link
Member

@mgol mgol Mar 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK then. I didn't seem the whole context on mobile so I thought this
line is new. :)

Michał Gołębiowski

@mgol
Copy link
Member

mgol commented Mar 28, 2016

What's the size difference?

@markelog
Copy link
Member Author

markelog commented Mar 28, 2016

The whole byte!

@timmywil
Copy link
Member

timmywil commented Mar 28, 2016

I like it 👍

@mgol
Copy link
Member

mgol commented Mar 28, 2016

Looks nice!

Michał Gołębiowski

@markelog markelog closed this in 44cb97e Mar 28, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markelog @mention-bot @mgol @timmywil @jquerybot