Skip to content

Conversation

@gibson042
Copy link
Member

Fixes gh-2986

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @rwaldron, @timmywil and @markelog to be potential reviewers

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@dmethvin
Copy link
Member

Hmmm. @gibson042 did you change your git sig? If not this may be a recent change to the CLA checker by @csnover.

@gibson042
Copy link
Member Author

I haven't changed my signature, but was wondering if the failure was caused by opening a PR with two commits.

@csnover
Copy link
Member

csnover commented Mar 14, 2016

I suspect I know what the problem is, apologies. One moment while I fix that.

csnover added a commit to jquery/jquery-license that referenced this pull request Mar 14, 2016
@@ -0,0 +1,3 @@
define( function() {
return Object.getPrototypeOf;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to protect against overwriting this field after loading jQuery?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No; just because it's smaller.

@timmywil timmywil closed this in e0d3bfa Apr 4, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

7 participants