-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Core: Simplify isPlainObject #2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
|
Hmmm. @gibson042 did you change your git sig? If not this may be a recent change to the CLA checker by @csnover. |
|
I haven't changed my signature, but was wondering if the failure was caused by opening a PR with two commits. |
|
I suspect I know what the problem is, apologies. One moment while I fix that. |
| @@ -0,0 +1,3 @@ | |||
| define( function() { | |||
| return Object.getPrototypeOf; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it to protect against overwriting this field after loading jQuery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No; just because it's smaller.
Fixes gh-2986