Skip to content

Core: Restore 1.x isPlainObject constructor checks #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Core: Restore 1.x isPlainObject constructor checks #2985

wants to merge 2 commits into from

Conversation

gibson042
Copy link
Member

Fixes gh-2982

To be merged into 2.2-stable and (probably) cherry-picked into master, although I would still like to see 3.0 revamped along the lines of #2970 (comment) .

timmywil pushed a commit that referenced this pull request Mar 14, 2016
@gibson042 @timmywil
Core: Restore 1.x isPlainObject constructor checks
0ef97b5 
- Guard isPlainObject against inherited scalar constructors

Fixes gh-2982
Close gh-2985
@timmywil timmywil closed this in 0c1f726 Mar 14, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibson042 @codeworrior @jquerybot