Skip to content

Conversation

@vitaliyterziev
Copy link
Contributor

additional tests and fixing typos in the old ones

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @timmywil, @markelog and @dmethvin to be potential reviewers

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@vitaliyterziev
Copy link
Contributor Author

@timmywil something was completely wrong with my previous pull and credentials, i ran the grunt and all tests passed by the way. I will try to verify my credentials with this pull

@mgol
Copy link
Member

mgol commented Jan 25, 2016

@vitaliyterziev Thanks for the PR! Your commits need to be signed by your full name as well. Please don't re-sign the CLA, we'll delete the wrong entries (cc @scottgonzalez), just amend the commit with your full name as the author. Click on "Details" next to the failed CLA check for more info about configuring git for that etc.

@vitaliyterziev
Copy link
Contributor Author

@mgol thanks for the clarifications and the guidance. All with the CLA seems fine now.

@vitaliyterziev
Copy link
Contributor Author

@timmywil I actually saw the problem in the style (the spacing) for better readability. Anyway this wasn't reported by the grunt run. I will fix it later

@markelog markelog mentioned this pull request Feb 2, 2016
@mgol
Copy link
Member

mgol commented Feb 15, 2016

@vitaliyterziev Will you have time to fix the spacing issues? Tabs should be used and it's better to not modify existing lines unless necessary.

@vitaliyterziev
Copy link
Contributor Author

@mgol i think that dimensions.js should be fine now, spaces are replaced by tabs and no unnecessary rows are touched

@mgol mgol added this to the 3.0.0 milestone Feb 24, 2016
@mgol
Copy link
Member

mgol commented Feb 24, 2016

Landed, thanks!

@mgol mgol closed this in f00dd0f Feb 24, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants