-
Notifications
You must be signed in to change notification settings - Fork 20.5k
#2700 negative border and padding tests #2869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
|
@timmywil something was completely wrong with my previous pull and credentials, i ran the grunt and all tests passed by the way. I will try to verify my credentials with this pull |
|
@vitaliyterziev Thanks for the PR! Your commits need to be signed by your full name as well. Please don't re-sign the CLA, we'll delete the wrong entries (cc @scottgonzalez), just amend the commit with your full name as the author. Click on "Details" next to the failed CLA check for more info about configuring git for that etc. |
d6a1a9c to
eec3634
Compare
|
@mgol thanks for the clarifications and the guidance. All with the CLA seems fine now. |
|
@timmywil I actually saw the problem in the style (the spacing) for better readability. Anyway this wasn't reported by the grunt run. I will fix it later |
|
@vitaliyterziev Will you have time to fix the spacing issues? Tabs should be used and it's better to not modify existing lines unless necessary. |
|
@mgol i think that dimensions.js should be fine now, spaces are replaced by tabs and no unnecessary rows are touched |
|
Landed, thanks! |
additional tests and fixing typos in the old ones