By analyzing the blame information on this pull request, we identified @mr21, @markelog and @timmywil to be potential reviewers

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

Thanks! If we can figure out a unit test, that would be great.

I like to see a test case added. http://jsbin.com/ruyecuxogu/edit?html,js,console,output would make a fine base (.css on an element created by jQuery.parseHTML with nontrivial input).

@timmywil I don't know what else to do to resolve this CLA error. I did the changes in my pull request directly in Github. Then when I filled in the CLA form and got the error I realized that I didn't have full name in my Github account. Then I filled my full name in Github, but the CLA error still remains. Finally I followed the instructions to update the git config, i.e:

git config --global user.name "YOUR NAME"
git config --global user.email "[email protected]"

and then:

# Switch to your branch
git checkout your-branch-name

# Amend the commit, setting the author based on your updated git config
git commit --amend --reset-author

# Push the amended commit to your fork
# Because the amended commit changed history, you need to force push (-f)
git push -f your-remote your-branch-name

still no luck.

@todorpr You have 2 commits in your PR and you amended only one. Can you squash them to one & try again?

@mgol I squashed the two commits into one using this guide: http://stackoverflow.com/a/18690845 but now my CLA page show 4 commits as the first one remains where my name is different from the rest:
http://contribute.jquery.org/CLA/status/?repo=jquery&sha=266004048f373af62beffd198bd09575d914e6aa

I'm not sure what should I do?

@todorpr You didn't squash it as the branch still contains a merge commit; this is how a Git tree looks like right now (pr/2867 is your branch):

You may also run:

git log --graph

in a console to see the tree in text mode.

It's best to avoid merges when working on something; you probably merged master to your branch which caused all those problems; you should be rebasing over master instead.

At this point it's easiest to run:

git reset --soft master

which will remove all your commits but keep the changes. You can then commit the change again, just copy the commit description somewhere so that you can paste it.

@mgol thanks, it's good now. Finally had to git push -f to update the repo.