Skip to content

Conversation

@timmywil
Copy link
Member

  • I think as long as existing tests pass, we're good.

Fixes gh-2488

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @gibson042, @gnarf and @markelog to be potential reviewers

@gnarf
Copy link
Member

gnarf commented Jan 19, 2016

I'm okay with this, but it scares the hell out of me.

Such a subtle difference such that all animations will now start at 0 instead of 1 for width and height, how long before someone "depends" on the 1 behavior... ¯\_(ツ)_/¯

@timmywil timmywil closed this in e04e246 Jan 21, 2016
@timmywil timmywil deleted the slidedown branch January 21, 2016 16:29
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants