Core: improve isNumeric logic #2827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/.jshintrc
Outdated
Member
There was a problem hiding this comment.
We usually reserve // Support:-style comments for supporting environments.
Add back accidentally deleted comments about the implementation. Add tests for new number literals. Ref jquery#2663 Ref jquery#2781 Ref jquery#2780
Contributor
Author
|
I have made the changes. Please have a look :) |
Member
|
Thanks @stevemao |
Contributor
Author
|
My pleasure :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back accidentally deleted comments about the implementation.
Add tests for new number literals.
Ref #2663
Ref #2781
Ref #2780