Traversing: Never let .closest() match positional selectors #2818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @markelog, @mariansollmann and @mikesherov to be potential reviewers |
Member
|
LGTM. I agree this is a good thing to change in 3.0, even though it's undocumented, just in case someone is using positional selectors in some crazy way. |
Member
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-2796
cf. #2796 (comment)
This changes a unit-tested behavior, but is not semver-major since the behavior was undocumented. Still, it probably should be included in 3.0 just in case.
Also adds a test for the acceptance of non-string input (e.g.,
$elem.closest( $possibleParents )).Best viewed with
-w.