Deferred: Remove undocumented progress notifications in $.when #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @markelog, @gibson042 and @jaubourg to be potential reviewers |
Member
There was a problem hiding this comment.
We currently don't have tests for progress in $.when
So we do have tests?
Member
Author
There was a problem hiding this comment.
Yes we did. However, the docs say nothing about it, and it seems strange to pass through the notifications from the subordinates all mixed into the master deferred.
Member
|
This looks pretty good to me. |
Member
Author
There was a problem hiding this comment.
Technically this could just be length but it seemed clearer to leave it this way.
Member
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-2710
Although we could add a new feature to notify on the new Deferred once each thenable resolved/rejected, it seemed like that would encourage more Deferred-specific behavior and I wasn't sure I wanted to go there. The important 3.0 behavior change here is removing the notification pass-through, which was undocumented. We can always add new functionality in a 3.x.0 if it's requested.