Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

I only want to fix a litter bug, why not?

CLA Verification Results

The name ufologist requires manual verification.

I have done below

1. Signing the CLA
2. Updating Git Config
3. git commit --amend --reset-author
4. git push -f origin master

Is ufologist your full name? The CLA check requires a full name (first & last) unless someone has a reason to hide it.

Thanks @mgol
ufologist is my nickname, but even I config and sign my full name, it does not work too.

CLA Verification Results

ufologist : Name on signature (xxx) doesn't match name on commit.

I need more help. :(

@ufologist Your commits must be signed by your full name as well. You can modify it via:

git commit --amend --author "FirstName LastName <email@address>"

You have 3 commits, though, every one of them would have to be modified. You might want to squash them to one commit first.

@jquery/core This is a mess, we're adding more & more stuff to this array and it'll always be a problem as CSS is expanding. I'd like to get rid of this px-appending but it might be too big a breaking change.

This is probably too late for 3.0 but how about switching the blacklist to a whitelist? If jQuery doesn't append px for you it's easier to fix by yourself than if it does append erroneously. My guess would be 99% of the uses are common properties like (min-|max-|)(height|width) or top, left etc. We could identify those most popular ones and append px only to them. Migrate could restore the previous behavior but warn if someone passes a numeric value to properties that are not on the current blacklist.

Would you mind creating another issue about it? Otherwise we might clutter this one.

Would you mind creating another issue about it? Otherwise we might clutter this one.

Right, created #2795 for that.

I'm looking at the added tests and the ones before it and they seem wrong... We're checking for truthiness of $div.css( "aProperty" ) just after we set it but if jQuery was erroneously adding px to values for this property then the browser would reject it and set an empty string which is falsy; this would lead us to incorrectly treat the browser as not supporting the property and, as a result, pass the test. Shouldn't we check:

$div.css( "aProperty" ) !== undefined

instead?

Thanks @mgol

I understand that set 'animation-iteration-count' by css() is not a common use.
But if not anyone find the same problem except me?

My guess would be 99% of the uses are common properties like (min-|max-|)(height|width) or top, left etc.

I accpet that

warn if someone passes a numeric value to properties that are not on the current blacklist.

Than I will know 'animation-iteration-count' property need added to jQuery.cssNumber by myself, or I can do css('animation-iteration-count', '2') passby the rule(use a string instead a numeric).

@ufologist Why this was closed?

I don't think @mgol comment was implying that we don't want your changes.

This PR is fine, I proposed changing an approach but that's a separate duscussion. This PR just needs changes I mentioned in my last comment. I'm reopening.

Landed on df822ca (master), b9a6958 (2.2-stable) & 01fb17b (1.12-stable). Thanks!