Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 7, 2015

Please feel free to squash/whatever;
No testing was done on this.
I've intentionally omitted fixes for external/ (there are 9), I found the upstream for them, and they've been landed:
qunitjs/qunit#898
jquery/sizzle#369

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @markelog, @gibson042 and @timmywil to be potential reviewers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is a fixed library, even if it's not a change to the api, it should remain as it is.

@leobalter
Copy link
Member

Besides the changes on test/data/jquery-1.9.1.js, it LGTM, no changes on the API.

@timmywil
Copy link
Member

timmywil commented Dec 7, 2015

I'd reiterate what @leobalter said. Once the change to jquery-1.9.1.js is reverted, we can land.

@jsoref
Copy link
Contributor Author

jsoref commented Dec 8, 2015

@timmywil: While there's no notification (!?), I've removed the changesets that touch that file, if you look at master, they're no longer present...

@dmethvin dmethvin closed this in aae4411 Jan 13, 2016
@dmethvin
Copy link
Member

@jsoref Thanks! 🌟

@jsoref
Copy link
Contributor Author

jsoref commented Nov 27, 2017

Fwiw, the tool is available at https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

@lock lock bot locked as resolved and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants