-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Spelling fixes #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling fixes #2761
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
|
By analyzing the blame information on this pull request, we identified @markelog, @gibson042 and @timmywil to be potential reviewers |
test/data/jquery-1.9.1.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is a fixed library, even if it's not a change to the api, it should remain as it is.
|
Besides the changes on |
|
I'd reiterate what @leobalter said. Once the change to |
|
@timmywil: While there's no notification (!?), I've removed the changesets that touch that file, if you look at master, they're no longer present... |
|
@jsoref Thanks! 🌟 |
|
Fwiw, the tool is available at https://github.com/jsoref/spelling |
Please feel free to squash/whatever;
No testing was done on this.
I've intentionally omitted fixes for
external/(there are 9), I found the upstream for them, and they've been landed:qunitjs/qunit#898
jquery/sizzle#369