Updated links to https where they are supported. #2746
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
| @@ -23,7 +23,7 @@ What you need to build your own jQuery | |||
|
|
|||
| In order to build jQuery, you need to have the latest Node.js/npm and git 1.7 or later. Earlier versions might work, but are not supported. | |||
|
|
|||
| For Windows, you have to download and install [git](http://git-scm.com/downloads) and [Node.js](http://nodejs.org/download/). | |||
| For Windows, you have to download and install [git](http://git-scm.com/downloads) and [Node.js](https://nodejs.org/download/). | |||
There was a problem hiding this comment.
I guess we can change it to https://nodejs.org/en/download/?
There was a problem hiding this comment.
@markelog 👍 The current URL seems to be non-human-friendly.
But it can be done in a separate commit as well.
There was a problem hiding this comment.
I would keep them in one commit, so we wouldn't "trash" the commit history
There was a problem hiding this comment.
I think it's fine to separate them: #2746 (comment).
Not very important, though.
|
LGTM. I think we can leave changing/dropping some URLs to separate commits, I like this one being focused just on changing http to https. |
No description provided.