Docs: add a note about loading source with AMD #2725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves the note about the watch task and the note about loading with AMD to their own section under "Test Suite Tips" Fixes jquerygh-2714
Member
|
All these changes LGTM! |
CONTRIBUTING.md
Outdated
Member
There was a problem hiding this comment.
Do we need that command at all?
Member
Author
There was a problem hiding this comment.
You do when following those steps to view the test page.
Member
There was a problem hiding this comment.
"npm run build" should take care of that, right now, it looks like you need to run both - grunt and npm commands
Regards,
Oleg
On 17 нояб. 2015 г., at 19:40, Timmy Willison [email protected] wrote:
In CONTRIBUTING.md:
-$ grunt && grunt watch +$ grunt You do when following those steps to view the test page.—
Reply to this email directly or view it on GitHub.
Member
Author
There was a problem hiding this comment.
Ah, of course. Didn't notice the run build line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-2714